remove redundant flag, initialize lists with capacity 1

dbus-notify
Zlatin Balevsky 2022-08-14 05:01:55 +01:00
parent 576c7d6934
commit cc29c9bd61
No known key found for this signature in database
GPG Key ID: A72832072D525E41
1 changed files with 5 additions and 8 deletions

View File

@ -23,7 +23,6 @@ public class SharedFile {
private volatile String comment; private volatile String comment;
private List<String> downloaders = Collections.emptyList(); private List<String> downloaders = Collections.emptyList();
private List<SearchEntry> searches = Collections.emptyList(); private List<SearchEntry> searches = Collections.emptyList();
private volatile boolean published;
private volatile long publishedTimestamp; private volatile long publishedTimestamp;
/** Path to the top-most parent File that is shared. Null if no such exists */ /** Path to the top-most parent File that is shared. Null if no such exists */
@ -96,11 +95,11 @@ public class SharedFile {
public synchronized void hit(Persona searcher, long timestamp, String query) { public synchronized void hit(Persona searcher, long timestamp, String query) {
List<SearchEntry> empty = Collections.emptyList(); List<SearchEntry> empty = Collections.emptyList();
if (searches == empty) if (searches == empty)
searches = new ArrayList<>(); searches = new ArrayList<>(1);
SearchEntry newEntry = new SearchEntry(searcher, timestamp, query); SearchEntry newEntry = new SearchEntry(searcher, timestamp, query);
if (!searches.contains(newEntry)) { if (!searches.contains(newEntry)) {
searches.add(newEntry); searches.add(newEntry);
((ArrayList)searches).trimToSize(); ((ArrayList<?>)searches).trimToSize();
} }
} }
@ -119,25 +118,23 @@ public class SharedFile {
public synchronized void addDownloader(String name) { public synchronized void addDownloader(String name) {
List<String> empty = Collections.emptyList(); List<String> empty = Collections.emptyList();
if (downloaders == empty) if (downloaders == empty)
downloaders = new ArrayList<>(); downloaders = new ArrayList<>(1);
if (!downloaders.contains(name)) { if (!downloaders.contains(name)) {
downloaders.add(name); downloaders.add(name);
((ArrayList)downloaders).trimToSize(); ((ArrayList<?>)downloaders).trimToSize();
} }
} }
public void publish(long timestamp) { public void publish(long timestamp) {
published = true;
publishedTimestamp = timestamp; publishedTimestamp = timestamp;
} }
public void unpublish() { public void unpublish() {
published = false;
publishedTimestamp = 0; publishedTimestamp = 0;
} }
public boolean isPublished() { public boolean isPublished() {
return published; return publishedTimestamp > 0;
} }
public long getPublishedTimestamp() { public long getPublishedTimestamp() {