From 4e09b4ad7172442f40daaf00094e42c70c5d5aea Mon Sep 17 00:00:00 2001 From: Zlatin Balevsky Date: Wed, 26 May 2021 08:01:48 +0100 Subject: [PATCH] forgot 0x --- .../core/connection/PeerConnection.groovy | 2 +- .../com/muwire/core/util/DataUtilTest.groovy | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/core/src/main/groovy/com/muwire/core/connection/PeerConnection.groovy b/core/src/main/groovy/com/muwire/core/connection/PeerConnection.groovy index a4803347..dfd3401a 100644 --- a/core/src/main/groovy/com/muwire/core/connection/PeerConnection.groovy +++ b/core/src/main/groovy/com/muwire/core/connection/PeerConnection.groovy @@ -80,7 +80,7 @@ class PeerConnection extends Connection { payload = (byte[]) message DataUtil.packHeader(payload.length, writeHeader) log.fine "$name writing binary message length ${payload.length}" - writeHeader[0] |= (byte)80 + writeHeader[0] |= (byte)0x80 } else throw new IllegalArgumentException() diff --git a/core/src/test/groovy/com/muwire/core/util/DataUtilTest.groovy b/core/src/test/groovy/com/muwire/core/util/DataUtilTest.groovy index 598d7f56..bdc9374d 100644 --- a/core/src/test/groovy/com/muwire/core/util/DataUtilTest.groovy +++ b/core/src/test/groovy/com/muwire/core/util/DataUtilTest.groovy @@ -32,6 +32,13 @@ class DataUtilTest { DataUtil.packHeader(value, header) assert value == DataUtil.readLength(header) } + + private static binaryHeader(int value) { + byte [] header = new byte[3] + DataUtil.packHeader(value, header) + header[0] |= (byte)0x80 + assert value == DataUtil.readLength(header) + } @Test void testHeader() { @@ -44,4 +51,17 @@ class DataUtilTest { fail() } catch (IllegalArgumentException expected) {} } + + @Test + void testBinaryHeader() { + binaryHeader(0) + binaryHeader(1) + binaryHeader(556) + binaryHeader(8 * 1024 * 1024 - 1) + try { + binaryHeader(8 * 1024 * 1024) + fail() + } catch (IllegalArgumentException expected) {} + + } }